Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified result handling - enabled all result handlers for the master alg #223

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

chria
Copy link
Collaborator

@chria chria commented Feb 27, 2024

No description provided.

Copy link
Collaborator

@PeterMeisrimelModelon PeterMeisrimelModelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, looks good overall, nice to get things a bit more unified!

src/pyfmi/fmi_algorithm_drivers.py Outdated Show resolved Hide resolved
src/pyfmi/fmi_algorithm_drivers.py Outdated Show resolved Hide resolved
src/pyfmi/master.pyx Show resolved Hide resolved
tests/test_fmi_master.py Show resolved Hide resolved
tests/test_fmi_master.py Show resolved Hide resolved
tests/test_fmi_master.py Show resolved Hide resolved
tests/test_fmi_master.py Show resolved Hide resolved
Copy link
Collaborator

@PeterMeisrimelModelon PeterMeisrimelModelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot in original review, can we add a Changelog note? Otherwise looks good to merge to me.
The GitHub actions shows failure, but that looks like an intermitted failure as far as I can tell from the log

@chria chria merged commit b191ca0 into master Feb 27, 2024
1 of 2 checks passed
@chria chria deleted the dev-cw-master-res branch February 27, 2024 18:41
modelonrobinandersson pushed a commit that referenced this pull request Apr 25, 2024
…alg (#223)

* Unified result handling - enabled all result handlers for the master algorithm

* Fixes after review

* Updated changelog

---------

Co-authored-by: chria <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants